Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es_ES isbn provider #2088

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add es_ES isbn provider #2088

merged 1 commit into from
Sep 4, 2024

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Aug 22, 2024

What does this change

Add es_ES isbn provider and refactor the base provider to simplify localized provider creation.

What was wrong

The base provider was not inheritable and the code assumptions there were confusing.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 2dc067e into joke2k:master Sep 4, 2024
28 checks passed
@mondeja mondeja deleted the isbn-es_ES branch September 4, 2024 14:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants