Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronized tables, separated requests and network logic and other... #8

Merged
merged 23 commits into from
Apr 7, 2018
Merged

Synchronized tables, separated requests and network logic and other... #8

merged 23 commits into from
Apr 7, 2018

Commits on Aug 3, 2017

  1. bump to 0.10.8

    @bcpclone
    bcpclone committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    9ab4ebb View commit details
    Browse the repository at this point in the history

  2. Update PULL_REQUEST_TEMPLATE

    @wkh237
    wkh237 committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    1336555 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2017

  1. Fix path argument in iOS excludeFromBackupKey (#473)

    @grylance @wkh237
    grylance authored and wkh237 committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    2aea0b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2017

  1. Fix README (#501) 

    remove extra space
    @moschan @wkh237
    moschan authored and wkh237 committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    821eeb0 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. Catch exceptions on sd card directories constants creation. Methods t… 

    …o get sd card directories. sd card directiories as constants deprecated warning
    Artur Chrusciel committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    22fd32a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Fix iOS initialization race condition (#499) 

    We have a crash in our application, and based on our analysis the culprit is a
race condition in RNFetchBlobNetwork initialization.

Crashing thread:

        Crashed: com.apple.root.default-qos
	0  libobjc.A.dylib                0x10416bacb objc_msgSend + 11
	1  Foundation                     0x103d3b644 -[NSObject(NSKeyValueObservingPrivate) _changeValueForKeys:count:maybeOldValuesDict:usingBlock:] + 153
	2  Foundation                     0x103c23f8c -[NSObject(NSKeyValueObservingPrivate) _changeValueForKey:key:key:usingBlock:] + 61
	3  Foundation                     0x103c23f3a -[NSOperationQueue setMaxConcurrentOperationCount:] + 198
	4  prymr                          0x100d579aa -[RNFetchBlobNetwork init] (RNFetchBlobNetwork.m:112)
	5  prymr                          0x100d63a73 __65-[RNFetchBlob fetchBlob:taskId:method:url:headers:body:callback:]_block_invoke (RNFetchBlob.m:131)
	6  prymr                          0x100d6006b __85+[RNFetchBlobReqBuilder buildOctetRequest:taskId:method:url:headers:body:onComplete:]_block_invoke (RNFetchBlobReqBuilder.m:178)
	7  libdispatch.dylib              0x107511585 _dispatch_call_block_and_release + 12

While a second thread is running:

	com.apple.root.default-qos
	0  libsystem_kernel.dylib         0x107891c22 __psynch_mutexwait + 10
	1  libsystem_pthread.dylib        0x1078c6dfa _pthread_mutex_lock_wait + 100
	2  libsystem_pthread.dylib        0x1078c4519 _pthread_mutex_lock_slow + 285
	3  Foundation                     0x103d3b615 -[NSObject(NSKeyValueObservingPrivate) _changeValueForKeys:count:maybeOldValuesDict:usingBlock:] + 106
	4  Foundation                     0x103c23f8c -[NSObject(NSKeyValueObservingPrivate) _changeValueForKey:key:key:usingBlock:] + 61
	5  Foundation                     0x103c23f3a -[NSOperationQueue setMaxConcurrentOperationCount:] + 198
	6  prymr                          0x100d579aa -[RNFetchBlobNetwork init] (RNFetchBlobNetwork.m:112)
	7  prymr                          0x100d63a73 __65-[RNFetchBlob fetchBlob:taskId:method:url:headers:body:callback:]_block_invoke (RNFetchBlob.m:131)
	8  prymr                          0x100d6006b __85+[RNFetchBlobReqBuilder buildOctetRequest:taskId:method:url:headers:body:onComplete:]_block_invoke (RNFetchBlobReqBuilder.m:178)
	9  libdispatch.dylib              0x107511585 _dispatch_call_block_and_release + 12

The patch just adds a dumb double-synchronization to the initialization.
    @mbarbon
    mbarbon authored and Artur Chrusciel committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    e46f94e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Synchronized dictionaries and tables operations

    Artur Chrusciel committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    38f4d75 View commit details
    Browse the repository at this point in the history

  2. Synchronized dictionaries and tables operations

    Artur Chrusciel committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    17cc8b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. Mostly RNFetchBlobNetwork cleanup

    Artur Chrusciel committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    905ab1c View commit details
    Browse the repository at this point in the history

  2. QOS level for task queue

    Artur Chrusciel committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    11f674c View commit details
    Browse the repository at this point in the history

  3. Unused completion handlers leftovers removed

    Artur Chrusciel committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    f0301db View commit details
    Browse the repository at this point in the history

  4. Separate requests from network logic

    Artur Chrusciel committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    8dd310d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Shared instance used

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    db68875 View commit details
    Browse the repository at this point in the history

  2. Proper usage of shared instance

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    ad65763 View commit details
    Browse the repository at this point in the history

  3. Commented code removed

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    1d19f98 View commit details
    Browse the repository at this point in the history

  4. Fixed header import defines

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    d4b465a View commit details
    Browse the repository at this point in the history

  5. Some code guidelines for network classes

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    57102f4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'synchronized' into exception_fixes

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f6fae9b View commit details
    Browse the repository at this point in the history

  7. Network activity calls on main thread

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    89d9b7a View commit details
    Browse the repository at this point in the history

  8. task cancelled error message

    Artur Chrusciel committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    a46bf81 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. Merge branch '0.10.9' into exception_fixes

    @chrusart
    chrusart committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    7cebeaa View commit details
    Browse the repository at this point in the history

  2. createFile methods with promises

    Artur Chrusciel committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    fb63db9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'exception_fixes' of github.com:flatfox-ag/react-native-… 

    …fetch-blob into exception_fixes
    Artur Chrusciel committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    01f38a4 View commit details
    Browse the repository at this point in the history