Audio countdown feedback #1192
Merged
Audio countdown feedback #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a countdown feedback trigger at 2x time until we're past halfway the original time. i.e a 10min countdown will have triggers at 4m 2m, 1m, 30s, 15s, 10s 5s, 4s, 3s, 2s 1s
gerhardol
reviewed
Aug 5, 2024
| @@ -521,7 +521,7 @@ private static void createAudioCountdown(Step step) { | |||
| case TIME: | |||
| // seconds | |||
| Double[] tmp0 = { | |||
| 60d, 30d, 10d, 5d, 3d, 2d, 1d | |||
| 60d, 30d, 10d, 5d, 4d, 3d, 2d, 1d | |||
There was a problem hiding this comment.
This is intentional for me, I do not want to be disturbed too much.
This is basically a 1,2,5,10,20,50 sequence modified for 60s and added 3
The 3 could be dropped.
Someone else have an opinion?
I could live with this.
There was a problem hiding this comment.
I would say dropping the 5 feels more natural than dropping the 3
gerhardol
reviewed
Aug 5, 2024
| @@ -536,6 +536,11 @@ private static void createAudioCountdown(Step step) { | |||
| return; | |||
| } | |||
|
|
|||
| // Extent the feedback list with more values for longer countdowns | |||
| while (step.getDurationValue() / 2 > list.get(0)) { | |||
| list.add(0, list.get(0) * 2d); | |||
There was a problem hiding this comment.
or add every minute?
OK for me
There was a problem hiding this comment.
I took doubling over every minute because it fits in the sequence and might be less disturbing, but I am fine with either
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm loving this app, but I had 2 small annoyances:
Since they are very small changes I just implemented them directly in a PR