Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese(zh-CN) support #937

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

chenzaichun
Copy link

Add simplified chinese translation.

Copy link
Collaborator

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but translated files must be added to Transifex, it is from there translations are pulled.
It may be possible to push translations as well.

Are both zh and zh-rCN needed?

@@ -57,6 +57,7 @@
<item>Suomi</item>
<item>Svenska</item>
<item>Türkçe</item>
<item>简体中文</item>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is intended to be in "alphabetic" sort order with local names. Is "Chinese" supposed to be sorted last like this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine.

@@ -16,6 +16,7 @@
~ along with this program. If not, see <http://www.gnu.org/licenses/>.-->
<string name="cue_activity">activity</string>
<string name="cue_interval">interval</string>
<string name="Cue_intervall_m">interval</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this string?
(may be an old string)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be an old string, I translated it last year. I use RunnerUp everyday, so I thinks maybe there's someone would like it.

There're some other zh format, like zh-TW, zh-HK, which use traditional Chinese. Maybe someone could translate it.

@gerhardol
Copy link
Collaborator

The Chinese translation in Transifex is empty, so the translations can be pushed (I have not used that function though).
But zh and zh-CN is identical, so only one of them is really needed (I suggest zh).
In addition a squash and rebase is needed.
I can do that, but unless you have allowed maintainer changes, it must be done in a PR I create.

@gerhardol
Copy link
Collaborator

What to keep of zh or zh-CN?
There will be a difference for users of Android before 7 from what I can see in
https://developer.android.com/guide/topics/resources/multilingual-support

using zh, those that has traditional get simplified instead of English which is probably a good thing
But as mixing traditional and simplified will likely look weird it may be better to keep zh-CN in Transifex

This can be changed (as is done for sv-SE in Transifex and sv in RU).

So unless you have other suggestions @chenzaichun I will do the following:

  • Squash and rebase
  • remove 'zh'
  • Push zh-CN to Transifex

@chenzaichun
Copy link
Author

@gerhardol sure, I think keep zh-CN is acceptable right now. I'll add translation for traditional chinese later. Thanls.

Use zh-CN on Transifex, map to 'zh' in the app for now
@gerhardol
Copy link
Collaborator

Translations pushed: https://www.transifex.com/runner-up/runner-up-android/language/zh_CN/

There are a few new strings to translate

I pushed a cleaned up commit to https://github.com/gerhardol/runnerup/tree/chenzaichun/chinese-support
Either reset your change to the latest commit, or I will open a separate PR (I cannot push to this PR)

@chenzaichun
Copy link
Author

@gerhardol I had added missing translation in transifex, but I don't know what can I do next. Could you please help? Should I add the missing translation to the xml and push to the PR again?

@gerhardol
Copy link
Collaborator

Register in transifex and up date there

@chenzaichun
Copy link
Author

already updated in transifex. :)

@gerhardol
Copy link
Collaborator

Can you make sure I can push to the branch (allow maintainers), then I will pull from Transifex to my squashed branch, push to this branch and merge

@chenzaichun
Copy link
Author

@gerhardol I reset the branch to the commit you squashed, and you could merge and push to this branch. Thanks.

@gerhardol gerhardol merged commit 63016e0 into jonasoreland:master Jul 9, 2020
@gerhardol
Copy link
Collaborator

Thanks

I did a fixup to Transifex zh for two arrays, pulled the updates in another PR (also merged)

@chenzaichun
Copy link
Author

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants