Implement oam_spr, conditionally emit methods
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the `oam_spr` method from neslib shows that some methods are optionally written to an NES binary. This makes sense, as they are trying hard to save space. To do this: * Walk the `TypeReference` table in IL, look for `NES.NESLib`. * Walk the `MemberReference` table in IL, saving any methods that are called from the `NES.NESLib` type. * At the end of `WriteFinalBuiltIns()`, write `oam_spr` if it is used. Co-authored-by: Mike Corsaro <corsarom@gmail.com>
Foda
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the
oam_sprmethod from neslib shows that some methods are optionally written to an NES binary. This makes sense, as they are trying hard to save space.To do this:
Walk the
TypeReferencetable in IL, look forNES.NESLib.Walk the
MemberReferencetable in IL, saving any methods that are called from theNES.NESLibtype.At the end of
WriteFinalBuiltIns(), writeoam_sprif it is used.