HNN and hnn-core incompatibility issue

[chenghuzi]

It seems hnn (old gui) only works with hnn-core v0.1 as in v0.2 some attributes changed, e.g., from net.params to net._params. Should we add some quick fix to the old repo or change the instruction there?

[rythorpe]

My vote would be to discontinue support for the legacy HNN GUI, since it would probably require much more than just a few quick fixes.

[jasmainak]

+1 … is there a reason you’re trying to get the old GUI working?

On Mon 23 Jan 2023 at 16:54, Ryan Thorpe ***@***.***> wrote: My vote would be to discontinue support for the legacy HNN GUI, since it would probably require much more than just a few quick fixes. — Reply to this email directly, view it on GitHub <#593 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADY6FIQWNHUXESQOYV5HRIDWT342NANCNFSM6AAAAAAUEH52GQ> . You are receiving this because you are subscribed to this thread.Message ID: <jonescompneurolab/hnn-core/repo-discussions/593/comments/4761062@ github.com>

-- Sent from my iPhone

[chenghuzi]

yeah I was trying to run the old gamma tutorial for comparison with the new one. But it's fine, I raised the question just because I found there's no version constraint in the old gui repo.

[jasmainak]

your GUI should be the new GUI with no version ambiguities :)