Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Commit

Permalink
Deduplicate dependencies and peerDependencies
Browse files Browse the repository at this point in the history
This should make it possible for `fc` to upgrade past v2, see https://github.com/careofvitamins/fc/pull/645#issuecomment-882796108

> Thanks for reviewing. I'm having some trouble resolving the merge conflict, will have to work on that and then re-request review.
>
> ```
> josephfrazier@C02WR4KZHTD615P:~/workspace/careof/fc/fulfillment$ yarn
> yarn install v1.22.10
> info Merge conflict detected in yarn.lock and successfully merged.
> [1/4] 🔍  Resolving packages...
> [2/4] 🚚  Fetching packages...
> info @ffmpeg-installer/darwin-arm64@4.1.5: The CPU architecture "x64" is incompatible with this module.
> info "@ffmpeg-installer/darwin-arm64@4.1.5" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/linux-arm@4.1.3: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/linux-arm@4.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/linux-arm@4.1.3: The CPU architecture "x64" is incompatible with this module.
> info @ffmpeg-installer/linux-arm64@4.1.4: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/linux-arm64@4.1.4" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/linux-arm64@4.1.4: The CPU architecture "x64" is incompatible with this module.
> info @ffmpeg-installer/linux-ia32@4.1.0: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/linux-ia32@4.1.0" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/linux-ia32@4.1.0: The CPU architecture "x64" is incompatible with this module.
> info @ffmpeg-installer/linux-x64@4.1.0: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/linux-x64@4.1.0" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/win32-ia32@4.1.0: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/win32-ia32@4.1.0" is an optional dependency and failed compatibility check. Excluding it from installation.
> info @ffmpeg-installer/win32-ia32@4.1.0: The CPU architecture "x64" is incompatible with this module.
> info @ffmpeg-installer/win32-x64@4.1.0: The platform "darwin" is incompatible with this module.
> info "@ffmpeg-installer/win32-x64@4.1.0" is an optional dependency and failed compatibility check. Excluding it from installation.
> [3/4] 🔗  Linking dependencies...
> warning " > styled-components@5.3.0" has unmet peer dependency "react-is@>= 16.8.0".
> warning " > eslint-config-careof@3.0.0" has incorrect peer dependency "eslint-plugin-jest@>= 24.3.6".
> warning " > mocha-multi@1.1.3" has incorrect peer dependency "mocha@>=2.2.0 <7.0.0".
> error An unexpected error occurred: "could not find a copy of eslint to link in /Users/josephfrazier/workspace/careof/fc/fulfillment/node_modules/eslint-config-careof/node_modules".
> info If you think this is a bug, please open a bug report with the information provided in "/Users/josephfrazier/workspace/careof/fc/fulfillment/yarn-error.log".
> info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
> josephfrazier@C02WR4KZHTD615P:~/workspace/careof/fc/fulfillment$
> ```
>
> Based on [yarnpkg/yarn#6285 (comment)](yarnpkg/yarn#6285 (comment)), it seems like this might be related to the fact that `eslint-config-careof` has `eslint` in multiple dependencies lists in the package.json: https://github.com/careofvitamins/eslint-config-careof/blob/b4725c781e6ef08a7f44264bea4a9a7b19d7fe92/package.json#L51-L67
>
> I'll try to see if I can get it working with a fork, then open a PR there.
  • Loading branch information
josephfrazier committed Jul 19, 2021
1 parent b4725c7 commit 175e348
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
},
"homepage": "https://github.com/careofvitamins/eslint-config-careof#readme",
"dependencies": {
"eslint": "^7.30.0",
"eslint-config-airbnb": "^18.2.1",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-security": "^1.4.0"
Expand Down

0 comments on commit 175e348

Please sign in to comment.