fix(InteriorLeftNav): allow arbitraty child node types (carbon-design…

…-system#540) Fixes carbon-design-system#534.
joshblack · Jan 29, 2018 · 0a86cb1 · 0a86cb1
1 parent 9d6d38c
commit 0a86cb1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/components/InteriorLeftNav/InteriorLeftNav-test.js b/src/components/InteriorLeftNav/InteriorLeftNav-test.js
@@ -32,13 +32,19 @@ describe('InteriorLeftNav', () => {
             className="test-child">
             <a href="http://www.carbondesignsystem.com">test-title</a>
           </InteriorLeftNavItem>
+          <div data-child-div>foo</div>
         </InteriorLeftNav>
       );
       expect(interiorLeftNav.find('.left-nav-list').length).toEqual(2);
       expect(interiorLeftNav.find('.test-child').length).toEqual(4);
       expect(
         interiorLeftNav.find('.bx--interior-left-nav-collapse').length
       ).toEqual(1);
+      expect(
+        interiorLeftNav
+          .find('[data-child-div]')
+          .matchesElement(<div data-child-div>foo</div>)
+      ).toBe(true);
     });
   });
 

diff --git a/src/components/InteriorLeftNav/InteriorLeftNav.js b/src/components/InteriorLeftNav/InteriorLeftNav.js
@@ -97,14 +97,12 @@ export default class InteriorLeftNav extends Component {
     } = this.props;
 
     const newChildren = React.Children.map(children, (child, index) => {
-      let newChild;
       if (child.type === InteriorLeftNavList) {
-        newChild = this.buildNewListChild(child, index);
-      } else {
-        newChild = this.buildNewItemChild(child, index);
+        return this.buildNewListChild(child, index);
+      } else if (child.type === InteriorLeftNavItem) {
+        return this.buildNewItemChild(child, index);
       }
-
-      return newChild;
+      return child;
     });
 
     const classNames = classnames(