Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot typecast req.body to string #43 #44

Merged
merged 1 commit into from
Aug 18, 2024
Merged

fix: Cannot typecast req.body to string #43 #44

merged 1 commit into from
Aug 18, 2024

Conversation

josselinonduty
Copy link
Owner

Improved parity / rewrote all the types used as request/response.

@josselinonduty josselinonduty added bug Something isn't working enhancement New feature or request labels Aug 18, 2024
@josselinonduty josselinonduty self-assigned this Aug 18, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/server/WrakerRouter.ts 37.03% 17 Missing ⚠️
src/server/Handler.ts 57.14% 3 Missing ⚠️
src/server/WrakerApp.ts 62.50% 3 Missing ⚠️
Files Coverage Δ
src/client/Wraker.ts 100.00% <100.00%> (ø)
src/server/Handler.ts 47.36% <57.14%> (+0.14%) ⬆️
src/server/WrakerApp.ts 69.23% <62.50%> (-3.50%) ⬇️
src/server/WrakerRouter.ts 59.43% <37.03%> (+1.02%) ⬆️

@josselinonduty josselinonduty merged commit 83c7d05 into dev Aug 18, 2024
3 of 4 checks passed
@josselinonduty josselinonduty deleted the 43-cannot-typecast-reqbody-to-string branch August 18, 2024 07:58
josselinonduty added a commit that referenced this pull request Aug 18, 2024
@josselinonduty
v0.4.0 (#47)
da0b8a2 
* chore(CD): remove abandoned workflow

* fix: Cannot typecast req.body to string #43 (#44)

* chore(tests): move tests types

* Case-sensitive methods/headers et al. (#46)

Fixes #45

* 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josselinonduty josselinonduty

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josselinonduty