Duration Import Bugfix

[chrisrosset]

This change makes the import look at duration and distance separately and imports the value provided by the user even if only one of them is provided.

Fixes #162.

[chrisrosset]

Fixes #523 too.

[reedy]

Any chance of before and after screenshots? :)

[chrisrosset]

Any chance of before and after screenshots? :)

Happy to oblige.

Test Case Overview

We have 4 cases:

1. Distance and duration both present
2. Distance but no duration
3. Duration but no distance
4. Both distance and duration missing

Test CSV

I have created a CSV with four JFK-LHR flights which map to our test cases. On its own, OpenFlights calculates the distance as 3440 miles and the duration as 07:22. I have purposefully chosen slightly different values for the user-provided values to make them easier to distinguish.

Date,From,To,Flight_Number,Airline,Distance,Duration,Seat,Seat_Type,Class,Reason,Plane,Registration,Trip,Note,From_OID,To_OID,Airline_OID,Plane_OID
2023-01-01,JFK,LHR,,Unknown,3500,07:45,,,Y,L,,,,,,,,
2023-01-01,JFK,LHR,,Unknown,3450,,,,Y,L,,,,,,,,
2023-01-01,JFK,LHR,,Unknown,,07:42,,,Y,L,,,,,,,,
2023-01-01,JFK,LHR,,Unknown,,,,,Y,L,,,,,,,,

Download link: pr-1212-duration-distance.csv

Before

Test cases 1 and 4 behave correctly:

• 1 shows user provided values from the CSV
• 4 shows synthetic values

Test cases 2 and 3 show undesirable behavior. The user provided values have been discarded and synthetic values are shown for both distance and duration.

After

• Test cases 1 and 4 behave as previously.
• Test case 2 now uses the distance from the CSV
• Test case 3 now uses the duration from the CSV