Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install on Python 3.12 #78

Closed
cdce8p opened this issue Jul 25, 2023 · 2 comments · Fixed by #83
Closed

Allow install on Python 3.12 #78

cdce8p opened this issue Jul 25, 2023 · 2 comments · Fixed by #83
Labels
dependencies Upgrade or downgrade of project dependencies.

Comments

@cdce8p
Copy link
Contributor

cdce8p commented Jul 25, 2023

The package requirements don't allow installs on 3.12 currently. That prohibits testing for applications that depend on this package, like Home Assistant. In general, it's better for libraries to keep their dependencies as open as possible for downstream apps to be able to resolve dependency conflicts. I would recommend >=3.9 here.

python = ">=3.9, <3.12"

--
As a side note, since I saw the discussion about the authlib pin, if the library is compatible with both <1.0 and >=1.0, it's usually better to use something like >=0.15. Once all other dependency are ready to upgrade and open up their respective pins, the authlib update will happen automatically.

authlib = "<1.0.0"

@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 25, 2023

Opened #79 to update the authlib requirement.

For Python, dataclasses-json needs to be updated first. Opened lidatong/dataclasses-json#449 for that. Once a new version is released, it can open a PR here to update it as well.

@jpbede
Copy link
Owner

jpbede commented Jul 26, 2023

Thanks a lot. I've merged the authlib requirement. I'm now waiting for dataclasses-json before I create a new release.

@jpbede jpbede added dependencies Upgrade or downgrade of project dependencies. python labels Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants