Fix Node DNS TXT record parsing regression #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not overwrite the hostname and ip address if told not to.
|
Sorry, wrong target repo ;) Closing |
|
@malaporte if this isn't the right target repo, then please can you let us know which is the right one? |
|
This was the right repo : https://github.com/coveord/eureka-js-client It's our own fork of the lib that has some changes to get it to work with recent Spring Boot - it's likely not suitable for anyone else. In other words, it was a PR targeting the same repo it's from - I clicked the wrong option or something when submitting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Node have this issue nodejs/node#52053 that prevent them from properly parsing the TXT records used by Eureka to resolve hosts.