Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragFromOutsideItem does not work in week view #2383

Closed
4 of 5 tasks
gnapse opened this issue Mar 20, 2023 · 4 comments · Fixed by #2651 · May be fixed by #2616
Closed
4 of 5 tasks

dragFromOutsideItem does not work in week view #2383

gnapse opened this issue Mar 20, 2023 · 4 comments · Fixed by #2651 · May be fixed by #2616

Comments

@gnapse
Copy link

gnapse commented Mar 20, 2023

Check that this is really a bug

  • I confirm

Reproduction link

http://jquense.github.io/react-big-calendar/examples/index.html?path=/docs/addons-drag-and-drop--example-3

Bug description

When using dragFromOutsideItem to give feedback as you drag over the calendar something from outside, the feedback item appears as expected when in month view, but not when in week view. In week view, it appears when dragging over the full-day events area. But it does not appear when dragging over the hourly planning area.

CleanShot.2023-03-20.at.14.18.24.mp4

Expected Behavior

I'd expect to get an event-like element appearing in the hourly planning area as I drag over it.

Actual Behavior

Nothing appears over the hourly planning are in a week or day view as I drag over an event from outside.

react-big-calendar version

1.6.8

React version

18.2.0

Platform/Target and Browser Versions

Any browser

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@gnapse gnapse added the bug label Mar 20, 2023
@digitalw
Copy link

Same goes for Day view.

@joeskyforged
Copy link

Any interest in fixing this? Makes dragFromOutsideItem completely useless for my use case

@Daveiano
Copy link

Daveiano commented Apr 3, 2024

For me, the same as for @joeskyforged applies, would be great if this could be fixed.

github-actions bot pushed a commit that referenced this issue Sep 16, 2024
## [1.14.1](v1.14.0...v1.14.1) (2024-09-16)

### Bug Fixes

* **dnd:** added check for null dragFromOutsideItem, updated example ([#2651](#2651)) ([17e62a3](17e62a3)), closes [#2616](#2616) [#2383](#2383)
Copy link

🎉 This issue has been resolved in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants