Added scrollTime prop like in FullCalendar #122
Conversation
| @@ -30,3 +30,7 @@ node_modules | |||
|
|
|||
| # Webstorm ide files | |||
| .idea | |||
|
|
|||
| # Example bundles | |||
There was a problem hiding this comment.
these are actually meant to be committed, they are for the docs
There was a problem hiding this comment.
Oops make sense, I'll add them then
There was a problem hiding this comment.
On a second note, I think you can generate them in npm preinstall but we can leave that for later.
|
@jquense I fixed all the issues you pointed out, let me know if there's anything else that needs work done |
| @@ -14,6 +14,7 @@ let Selectable = React.createClass({ | |||
| selectable | |||
| events={events} | |||
| defaultView='week' | |||
| defaultTimeScroll={new Date(1970, 1, 1, 17)} | |||
There was a problem hiding this comment.
this isn't a better name I don't think. the "default" version of props also have a non default counterpart (this does not). Default props also imply that the prop is only set once which isn't true in this case. can we use scrollToTime instead?
|
Fixed. I also squashed it all under one commit. |
| componentWillReceiveProps(nextProps) { | ||
| const { start, scrollTop } = this.props; | ||
| // When paginating, reset scroll | ||
| if (!dates.eq(nextProps.start, start) || nextProps.scrollTop !== scrollTop) { |
There was a problem hiding this comment.
dates.eq(nextProps.start, start, 'day') and probably the same for: nextProps.scrollTop !== scrollTop no? Well not 'day' but perhaps 'minutes', ie only recalculate with the scrollToTime has changed more than a minute.
Also scrollTop is wrong here right?
There was a problem hiding this comment.
scrollTop wrong, yes. The condition, however is correct, because it only calculates the new scroll value when the start is different (i.e. it has changed dates or paginated) or when the scrollToTime prop has changed.
|
ok thanks for the updates, I finally had a chance to give it a real close look, just a few concerns |
|
many thanks |
|
Thank you for creating this plugin! Are you planning a release anytime soon? |
I added a new prop scrollTime so that the TimeGrid view is initially scrolled down to a specified hour on every mount or change of prev/next week. Let me know if I need to add any checks!
Original prop: http://fullcalendar.io/docs/agenda/scrollTime/
Takes a Date object, which I don't find really useful (a moment.duration would be more suitable, or an amount in millis, but I get how this is moment-agnostic) but props
minandmaxused that too so I figured I'd use the same method :)