added component override for time gutter wrapper #1761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvgoel92
reviewed
Jul 12, 2022
| return ( | ||
| <div className="rbc-time-gutter rbc-time-column"> |
There was a problem hiding this comment.
I think we can keep this div as is and create a wrapper with default </> around it? If someone wants to override the class names, they will be able to.
| return ( | ||
| <div className="rbc-time-gutter rbc-time-column"> | ||
| <Wrapper className="rbc-time-gutter rbc-time-column"> | ||
| {this.slotMetrics.groups.map((grp, idx) => { |
There was a problem hiding this comment.
We can pass this.slotMetrics as an argument to the wrapper to make it more powerful. A good use case for this might be for a wrapper to render "multiple" TimeSlotGroup to support multi-timezone time view.
|
@zshannon will it be okay with you if I collaborate on this PR and take it forward? |
|
yup, i'm not going to add anymore here. good luck! |
|
I have build on this here: #2236 I think we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.