Correct listeners reference in the Selections.teardown() method #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge of latest head changes
merging latest from base project
chore: upgrade storybook (jquense#1308)
chore(deps): update overlay (jquense#1301)
feat: switch to Sass for styles
docs(storybook): storybook theme (jquense#1317)
merging parent changes
fix: Correct duration in DnD (jquense#2034)
Fix the `Selection.teardown()` method to reference the correct variable jquense#2072
|
@jquense Can you review this one please? Think this minor fix could repair some performance issues. |
jquense
approved these changes
Dec 17, 2021
|
🎉 This PR is included in version 0.38.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue where the
teardownwas not properly referencing the internal_listenersproperty of the class.This addresses Issue #2072