fix: prevent unhandled Promise rejection when returning rejected Prom…

…ise inside test function (#1327)
jquense · Apr 4, 2021 · 5eda549 · 5eda549
1 parent 91ace1e
commit 5eda549
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/util/createValidation.ts b/src/util/createValidation.ts
@@ -120,7 +120,7 @@ export default function createValidation(config: {
           if (ValidationError.isError(validOrError)) cb(validOrError);
           else if (!validOrError) cb(createError());
           else cb(null, validOrError);
-        });
+        }).catch(cb);
       } catch (err) {
         cb(err);
       }

diff --git a/test/mixed.js b/test/mixed.js
@@ -529,6 +529,16 @@ describe('Mixed Types ', () => {
       });
   });
 
+  it('should fail when the test function returns a rejected Promise', async () => {
+    let inst = string().test(() => {
+      return Promise.reject(new Error('oops an error occurred'))
+    });
+
+    return inst
+      .validate('joe')
+      .should.be.rejected();
+  });
+
   describe('withMutation', () => {
     it('should pass the same instance to a provided function', () => {
       let inst = mixed();