Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MixedSchema to fix ts with --declarations #1204

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

janicduplessis
Copy link
Contributor

Fixes ts error Exported variable 'Schema' has or is using name 'MixedSchema' from external module "x/node_modules/yup/lib/mixed" but cannot be named. with --declarations builds.

The MixedSchema class needs to be exported so it can be used in declaration files.

Fixes ts error `Exported variable 'Schema' has or is using name 'MixedSchema' from external module "x/node_modules/yup/lib/mixed" but cannot be named.` with --declarations builds.

The MixedSchema class needs to be exported so it can be used in declaration files.
@Gohsato
Copy link

Gohsato commented Jan 4, 2021

I think this pr would solve #1162!

@MartinCerny-awin
Copy link

Can we please merge this PR?

@jquense
Copy link
Owner

jquense commented Jan 11, 2021

Haven't had the time to try this out, but hoping to make some this week

@Shandur
Copy link

Shandur commented Jan 15, 2021

@jquense Looking forward to seeing it merged too 👍

@dko-slapdash
Copy link

+1

It's a simple change consistent to what e.g. object.d.ts or number.d.ts have, and no risk of regressions @jquense - the button "Merge" can just be pressed without even testing.

@jquense
Copy link
Owner

jquense commented Jan 20, 2021

every TS change needs to be tested, unfortunately @dko-slapdash the smallest change can have large, or to picture effects.

@jquense jquense merged commit 67c96ae into jquense:master Jan 20, 2021
@janicduplessis janicduplessis deleted the patch-1 branch January 21, 2021 18:11
@janicduplessis
Copy link
Contributor Author

Thanks @jquense !

@pkolt
Copy link

pkolt commented Jan 24, 2021

@jquense Hi! When will the version with this patch be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants