Fixed bug #544

TODO.md

@@ -1,7 +1,5 @@
 # 1.8.3
 
-    - Fix integer generation bug: https://github.com/jqwik-team/jqwik/issues/544
-
     - Summon preconfigured arbitrary. See https://github.com/jqwik-team/jqwik/issues/527
 
 # 1.8.x

engine/src/main/java/net/jqwik/engine/properties/arbitraries/randomized/UniformRandomDistribution.java

@@ -23,8 +23,10 @@ public RandomNumericGenerator createGenerator(
 	}
 
 	private static boolean isWithinIntegerRange(BigInteger min, BigInteger max) {
-		return min.compareTo(BigInteger.valueOf(Integer.MIN_VALUE)) >= 0
-			&& max.compareTo(BigInteger.valueOf(Integer.MAX_VALUE)) <= 0;
+		boolean rangeIsSmallerThanIntegerMax = max.subtract(min).compareTo(BigInteger.valueOf(Integer.MAX_VALUE)) < 0;
+		boolean minAndMaxAreWithinInt = min.compareTo(BigInteger.valueOf(Integer.MIN_VALUE)) >= 0
+						&& max.compareTo(BigInteger.valueOf(Integer.MAX_VALUE)) <= 0;
+		return rangeIsSmallerThanIntegerMax && minAndMaxAreWithinInt;
 	}
 
 	@Override

engine/src/test/java/net/jqwik/api/ArbitrariesTests.java

@@ -795,6 +795,24 @@ void integersInt(@ForAll Random random) {
 			checkAllGenerated(generator, random, value -> value >= -10 && value <= 10);
 		}
 
+		@Property(tries = 10)
+		void integersFullRangeWithUniformDistribution(@ForAll Random random) {
+			Arbitrary<Integer> integerArbitrary =
+				Arbitraries.integers()
+						   .withDistribution(RandomDistribution.uniform());
+			RandomGenerator<Integer> generator = integerArbitrary.generator(1);
+
+			TestingSupport.checkAllGenerated(
+				generator,
+				random,
+				value -> value >= Integer.MIN_VALUE && value <= Integer.MAX_VALUE
+			);
+			TestingSupport.checkAtLeastOneGenerated(generator, random, value -> value > 0 && value < Integer.MAX_VALUE);
+			TestingSupport.checkAtLeastOneGenerated(generator, random, value -> value < 0 && value > Integer.MIN_VALUE);
+		}
+
+
+
 		@Example
 		void longMinsAndMaxesWithEdgeCases(@ForAll Random random) {
 			RandomGenerator<Long> generator = Arbitraries.longs().generator(1, true);