Convert string to bytes if needed #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When django-storages is used from an app which is configured by env variables fed into dynaconf (or probably other situations), it's not easy to directly coerce a string representation of the signing key into a bytes-like object; it comes in as a string. This detects that situation and encodes the string.
|
Thanks, looks great. Hopefully merging kicks CI. |
|
Guess we could have used Django's |
|
My Django skills are very weak. :) |
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
When django-storages is used from an app which is configured by env variables fed into dynaconf (or probably other situations), it's not easy to directly coerce a string representation of the signing key into a bytes-like object; it comes in as a string. This detects that situation and encodes the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When django-storages is used from an app which is configured by env variables
fed into dynaconf (or probably other situations), it's not easy to directly
coerce a string representation of the signing key into a bytes-like object; it
comes in as a string. This detects that situation and encodes the string.