Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github CI to replace travis CI #1051

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Sep 6, 2021

Description

This migrates Travis CI configuration to Github actions. This approach was discussed here as a consequence of Travis CI changing support for open source projects.

Concerns

  • Should we keep the Travis CI configuration?
  • Which python version was being used for the quality checks?
  • On which events should we trigger testing?

@mariajgrimaldi
Copy link
Contributor Author

Hey! @jschneier

I think Github Actions are not enabled

@jschneier
Copy link
Owner

@mariajgrimaldi that isn't what I see but it's not clear to me why it isn't running.

@jschneier
Copy link
Owner

@mariajgrimaldi for your questions

  1. You can also ahead and delete the Travis stuff
  2. For linting, it would be ideal if the minimum version of Python was used but I don't think it overly matters
  3. Tests should run on PR open and PR update (push to PR). It should also run against trunk after merging.

@mariajgrimaldi
Copy link
Contributor Author

mariajgrimaldi commented Sep 7, 2021

Thanks for the response @jschneier! I used python 3.6 for this restriction: https://github.com/jschneier/django-storages/blob/master/tox.ini#L55

Also, do you know why checks are not running? They do here: https://github.com/mariajgrimaldi/django-storages/pull/1/checks

Is it because it is from a fork?

@jschneier
Copy link
Owner

Unclear, I think because I didn't "set it up" myself. I'm going to commit this and see what happens.

@jschneier jschneier merged commit aa75456 into jschneier:master Sep 7, 2021
@jschneier
Copy link
Owner

@mariajgrimaldi yup! Looks like it's working!

https://github.com/jschneier/django-storages/actions/runs/1209946412

@mariajgrimaldi
Copy link
Contributor Author

excellent!! @jschneier, thanks for the help. Can you make a release with these changes?

@natabene
Copy link

@jschneier Just checking if you could look into doing a release with this changes some time soon. I would greatly appreciate, as it would really help our Django upgrade project for the Open edX Platform.

mlazowik pushed a commit to qedsoftware/django-storages that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants