Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] Add AZURE_CLIENT_OPTIONS setting #1432

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

daviddavis
Copy link
Contributor

@daviddavis daviddavis commented Jul 11, 2024

@daviddavis daviddavis force-pushed the azure-retry-setting branch 2 times, most recently from bcbe331 to fea4f29 Compare July 11, 2024 13:18
@jschneier
Copy link
Owner

Thanks for the PR. Have seen this one before! Can you please add a setting like AZURE_CLIENT_OPTIONS so that we don’t end up needing a separate setting for each.

Them we will deprecate the API_ VERSION one.

@daviddavis daviddavis changed the title Add AZURE_RETRY_TOTAL setting Add AZURE_CLIENT_OPTIONS setting Jul 17, 2024
@daviddavis
Copy link
Contributor Author

@jschneier thanks for the feedback. I've updated the PR.

This allows users to customize the kwarg options for the
BlobServiceClient.

This change also deprecates the AZURE_API_VERSION setting as well.
@jschneier jschneier changed the title Add AZURE_CLIENT_OPTIONS setting [azure] Add AZURE_CLIENT_OPTIONS setting Jul 20, 2024
@jschneier jschneier merged commit 123b9b9 into jschneier:master Jul 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants