Rewrite S3Boto3Storage.listdir() for efficiency #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
========================================
- Coverage 77.1% 76.6% -0.5%
========================================
Files 10 11 +1
Lines 1520 1603 +83
========================================
+ Hits 1172 1228 +56
- Misses 348 375 +27
Continue to review full report at Codecov.
|
|
@jdufresne is this still relevant? |
|
It should be more efficient than the previous version, so I think so. Did you have specific concerns or reservations? |
Use boto3 paginator to fetch results. Code based on django-s3-storage. Fixes #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use boto3 paginator to fetch results. Code based on django-s3-storage.
Fixes #95