Reverse mixin order, otherwise StorageMixin is ineffective. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorageMixin is supposed to isolate the new `max_length` feature to Django-1.8 and later, but it wasn't actually doing anything because the MRO is backwards.
jschneier
added a commit
that referenced
this pull request
Aug 14, 2015
|
Thanks! I added a failing test case. |
jschneier
added a commit
that referenced
this pull request
Aug 14, 2015
Reverse mixin order, otherwise StorageMixin is ineffective.
jschneier
added a commit
that referenced
this pull request
Aug 14, 2015
This was referenced Jul 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageMixin is supposed to isolate the new
max_lengthfeature toDjango-1.8 and later, but it wasn't actually doing anything because the MRO
is backwards.