Allow SFTPStorage to be configured via class variables #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorJohn
force-pushed
the
better-sftpstorage-subclassing
branch
from
658b1e8
to
efc9046
Compare
Closed
|
Can you please rebase |
|
It looks good, will merge after |
|
I think this should hold off until #524 lands, and then use the approach developed there. That way we don't end up with the same issue in the SFTPStorage backend. |
DoctorJohn
force-pushed
the
better-sftpstorage-subclassing
branch
from
efc9046
to
c3c9060
Compare
|
@jschneier I rebased, however @jdufresne has a point. After #524 landed, I could alter this PR or drop it and create a new one, that has the same affect but uses "the style" introduced in #524. |
|
The other PR has landed, this could be rebased and updated if you'd like. |
|
@DoctorJohn are you interested in updating this? I'm going to make another release imminently. |
DoctorJohn
force-pushed
the
better-sftpstorage-subclassing
branch
2 times, most recently
from
8b24816
to
102e813
Compare
DoctorJohn
force-pushed
the
better-sftpstorage-subclassing
branch
from
102e813
to
4bea4fb
Compare
|
@jschneier I just updated the SFTPStorage backend to use the settings mechanism introduced in #524 while keeping everything backwards compatible. |
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the SFTPStorage class configurable via class variables (similar to other backends). That way subclassing is more convenient. (#851).
As far as I can tell, these changes are backwards compatible.