Write mode option for Dropbox #873
Conversation
storages/backends/dropbox.py
Outdated
| @@ -89,6 +93,9 @@ def delete(self, name): | |||
| self.client.files_delete(self._full_path(name)) | |||
|
|
|||
| def exists(self, name): | |||
| if self.overwrite: | |||
There was a problem hiding this comment.
so how then to make Django to not rename? any suggestions?
There was a problem hiding this comment.
Look at the other backends. They override get_available_name.
There was a problem hiding this comment.
@jschneier updated
storages/backends/dropbox.py
Outdated
| @@ -132,7 +139,7 @@ def _open(self, name, mode='rb'): | |||
| def _save(self, name, content): | |||
| content.open() | |||
| if content.size <= self.CHUNK_SIZE: | |||
| self.client.files_upload(content.read(), self._full_path(name)) | |||
| self.client.files_upload(content.read(), self._full_path(name), mode=WriteMode('overwrite')) | |||
There was a problem hiding this comment.
The mode isn't constant. It needs to depend on what the user wants.
There was a problem hiding this comment.
django checks for exists, if it's true - it renames, so the mode does not actually metter
There was a problem hiding this comment.
@jschneier so, can I then add WriteMode as an option?
There was a problem hiding this comment.
@jschneier updated, made as an option
storages/backends/dropbox.py
Outdated
| @@ -158,3 +166,24 @@ def _chunked_upload(self, content, dest_path): | |||
| content.read(self.CHUNK_SIZE), cursor | |||
| ) | |||
| cursor.offset = content.tell() | |||
|
|
|||
| def _clean_name(self, name): | |||
There was a problem hiding this comment.
I think you can just use self._full_path instead here since that seems to work.
| Overwrite an existing file when it has the same name as the file being uploaded. | ||
| Otherwise, rename it. Default is ``False`` | ||
|
|
||
| ``DROPBOX_WRITE_MODE`` (optional) |
There was a problem hiding this comment.
Can you default this to whatever the current default is (not overwrite). Don't want to break backwards compat. Can you also link out to the Dropbox docs for this property.
There was a problem hiding this comment.
changed to 'add'
storages/backends/dropbox.py
Outdated
| def get_available_name(self, name, max_length=None): | ||
| """Overwrite existing file with the same name.""" | ||
| name = self._clean_name(name) | ||
| if self.file_overwrite: |
There was a problem hiding this comment.
Here you can just check if self.write_mode == 'overwrite'.
There was a problem hiding this comment.
@jschneier can you review please ?
petriichuk
changed the title
|
Looks great. @petriichuk did you test it? |
of course, I already use it. |
* added overwrite option * added myself as AUTHOR * Refactored to native feature implementation after comment from package owner * Make write mode as external option, with default set to overwrite * Fix order of imports * added new options description * fixed import sort issue * removed redundand option, updated documentation * replaced _clean_name by _full_path * update author change comment * removed unused import posixpath Co-authored-by: Taras Petriichuk <taraspetriichuk@TX-N-0432.local>
* added overwrite option * added myself as AUTHOR * Refactored to native feature implementation after comment from package owner * Make write mode as external option, with default set to overwrite * Fix order of imports * added new options description * fixed import sort issue * removed redundand option, updated documentation * replaced _clean_name by _full_path * update author change comment * removed unused import posixpath Co-authored-by: Taras Petriichuk <taraspetriichuk@TX-N-0432.local>
Adding the possibility to overwrite existing files at Dropbox instead of allowing Django change it's name.