Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output can be cut off in node 4 #1070

Closed
Macil opened this issue Sep 23, 2015 · 2 comments · Fixed by #1082
Closed

Output can be cut off in node 4 #1070

Macil opened this issue Sep 23, 2015 · 2 comments · Fixed by #1082

Comments

@Macil
Copy link

Macil commented Sep 23, 2015

Between node 0.12 and 4.0, writes to stdout are no longer synchronous, but it appears that jsdoc can call process.exit before writes are complete, so jsdoc's output can be cut off. See nodejs/node#3033 and nodejs/node#2972.
@tschaub
Copy link
Contributor

tschaub commented Sep 24, 2015

I think the alternatives here are to have JSDoc not call process.exit() (on success), to have all templates return promises and use a version of JSDoc with the changes from #953, or to wait for a change in Node.

nicksay added a commit to nicksay/jsdoc that referenced this issue Oct 7, 2015
@nicksay
Prevent output from being cut off in Node 4
dee4dab 
This is a quick fix for truncated output in Node 4 by only calling
`process.exit` for errors.

Closes jsdoc#1070
@nicksay nicksay mentioned this issue Oct 7, 2015
Merged
@tschaub tschaub mentioned this issue Oct 12, 2015
Merged
Macil added a commit to InboxSDK/InboxSDK that referenced this issue Oct 19, 2015
@Macil
Work around jsdoc/jsdoc#1070
a385553
nicksay added a commit to nicksay/jsdoc that referenced this issue Nov 2, 2015
@nicksay
Prevent output from being cut off in Node 4
27f592a 
This is a quick fix for truncated output in Node 4 by only calling
`process.exit` for errors.

Closes jsdoc#1070
@hegemonic
Copy link
Contributor

Fixed on master. Sorry for the long delay in getting this merged.

Macil added a commit to InboxSDK/InboxSDK that referenced this issue Dec 17, 2015
@Macil
Revert "Work around jsdoc/jsdoc#1070"
3027215 
This reverts commit a385553.

The bug was fixed in jsdoc.
@BryanDonovan BryanDonovan mentioned this issue Jan 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tschaub @Macil @hegemonic