Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] anchor-is-valid: general cleanup #728

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Conversation

Anima-t3d
Copy link
Contributor

Changed L48, the rest is just formatting.

 - swap `div` for `span`, since `a` is an inline element.
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a ton of reformatting here, and it's not clear what typo this is fixing? "different to a" and "different than a" are equivalent.

Comment on lines 94 to 95
>
onMouseEnter={() => this.setState({ showSomething: true })}>{label}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this introduces a syntax error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue I wanted to address was the change from div to span. The formatting must have been my IDE setting, I thought it followed the project settings.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are overall an improvement, so let's just merge it

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #728 (0a70138) into master (3df059e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1452     1452           
  Branches      477      477           
=======================================
  Hits         1441     1441           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df059e...c275964. Read the comment docs.

@ljharb ljharb changed the title docs: fix typo [Docs] anchor-is-valid: general cleanup Feb 20, 2021
@ljharb ljharb merged commit c275964 into jsx-eslint:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants