Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unknown-property: allow fill prop on <symbol> #3555

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

stefanprobst
Copy link
Contributor

this adds fill to the list of allowed props for <symbol> in no-unknown-props. see https://developer.mozilla.org/en-US/docs/Web/SVG/Element/symbol#global_attributes

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3555 (1122738) into master (f56851b) will increase coverage by 97.61%.
The diff coverage is n/a.

❗ Current head 1122738 differs from pull request most recent head 492c34c. Consider uploading reports for the commit 492c34c to get more accurate results

@@             Coverage Diff             @@
##           master    #3555       +/-   ##
===========================================
+ Coverage        0   97.61%   +97.61%     
===========================================
  Files           0      132      +132     
  Lines           0     9289     +9289     
  Branches        0     3396     +3396     
===========================================
+ Hits            0     9067     +9067     
- Misses          0      222      +222     
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <ø> (ø)

... and 131 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb changed the title fix(no-unknown-property): allow fill prop on symbol [Fix] no-unknown-property: allow fill prop on <symbol> Apr 4, 2023
@ljharb ljharb merged commit 492c34c into jsx-eslint:master Apr 4, 2023
@stefanprobst stefanprobst deleted the fix/symbol-fill-prop branch April 5, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants