Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e scenarios #24

Closed
jthegedus opened this issue Mar 22, 2021 · 3 comments
Closed

test: e2e scenarios #24

jthegedus opened this issue Mar 22, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jthegedus
Copy link
Owner

Is your feature request related to a problem? Please describe.

It would be good to get some e2e tests that ensured the adapter output was in a working state once deployed to an environment.

Running svelte-kit build followed by the Firebase emulator should be possible in CI with some curls and assertions on the HTML responses.

Describe the solution you'd like

A self-contained CI implementation, preferrably using the Firebase emulator.

Describe alternatives you've considered

Deploying to an actual Firebase project.

Additional context

@jthegedus jthegedus added the enhancement New feature or request label Mar 22, 2021
@jthegedus jthegedus changed the title e2e tests test: e2e scenarios Mar 22, 2021
@jthegedus jthegedus self-assigned this Mar 23, 2021
@jthegedus
Copy link
Owner Author

Related: sveltejs/kit#639

A clone of the example app built for testing the official adapters would be ideal.

@jthegedus
Copy link
Owner Author

#52 introduced integration tests with 2 example apps, though we need more integration tests and e2e tests.

Since Cloud Run deployments cannot be tested using the Firebase Emulator, we will need to actually deploy to production projects and check curl responses.

@jthegedus
Copy link
Owner Author

#123 added e2e tests with the Firebase Emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant