Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not installable with npm #44

Closed
nhe23 opened this issue May 6, 2021 · 11 comments · Fixed by #46, #48 or #49
Closed

Module not installable with npm #44

nhe23 opened this issue May 6, 2021 · 11 comments · Fixed by #46, #48 or #49
Labels

Comments

@nhe23
Copy link

nhe23 commented May 6, 2021

Describe the bug
Current version 0.6.1 is not installable with npm. When I use pnpm it works. However the container does not build on CloudRun because it also has this problem.

To Reproduce

  1. Initialize svelte kit demo app
  2. Add "svelte-adapter-firebase": "^0.6.1" as devDependency in package.json
  3. run npm i
  4. See error

Expected behavior
npm install should work and container should build on CloudRun

Screenshots
image
image

@nhe23
Copy link
Author

nhe23 commented May 6, 2021

Another thing I found:
image

This can be reproduced by using the sveltekit demo app and using the 'svelte-adapter-firebase' adapter in the current version. When I copied the package.json ('my-app/node_modules/.pnpm/svelte-adapter-firebase@0.6.1_svelte@3.38.2+vite@2.2.4/node_modules/svelte-adapter-firebase/package.json) to 'my-app/node_modules/.pnpm/svelte-adapter-firebase@0.6.1_svelte@3.38.2+vite@2.2.4/node_modules/svelte-adapter-firebase/src/package.json' the error disappeared. But the deployment to cloud run did not work after that because of the error described in this issue. @jthegedus Should I add a separate issue for this?

@jthegedus
Copy link
Owner

jthegedus commented May 6, 2021

Should I add a separate issue for this?

I think this will be the result of the same issue. I thought i was able to force development to occur with pnpm, but that has obviously affected CloudBuild build step which with Buildpacks always uses npm

I will fix momentarily.

I need to work out #24 as it would likely pick up these issues

@jthegedus
Copy link
Owner

@nhe23 You will need to test Cloud Run with the changes in 0.6.2 when 0.6.3 (fix for this) releases.

@jthegedus
Copy link
Owner

I will work on #24 next so these types of issues get caught sooner. Apologies 🙏

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

🎉 This issue has been resolved in version 0.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nhe23
Copy link
Author

nhe23 commented May 7, 2021

@nhe23 You will need to test Cloud Run with the changes in 0.6.2 when 0.6.3 (fix for this) releases.

I just installed the new version and it is now installable with npm. However running npm run buildcauses the following error:
image

@jthegedus
Copy link
Owner

@nhe23 Can you open a new Issue?

Also, I no longer compile the adapter, so feel free to go to that node_modules/svelte-adapter-firebase/src/index.js:108:31 file and edit the code to test solutions.

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.6.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jthegedus
Copy link
Owner

@nhe23 I missed some commits in #43 which had the fix for your issue, sorry about that. New release should have the fix.

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.6.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jthegedus
Copy link
Owner

@nhe23 I'll get this right eventually, try that new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment