Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dashmap dependency #145

Merged
merged 2 commits into from
May 5, 2024
Merged

Conversation

xmakro
Copy link

@xmakro xmakro commented Apr 29, 2024

Also increments version. Please push a new release.

Pinning the version of dashmap means that crates that depend on html2text cannot use a newer version of dashmap

@jugglerchris
Copy link
Owner

It's definitely a mistake that dashmap is a non-optional dependency - it should only be used when the css feature is enabled.

However, it's there for a reason - I'm currently aiming to support Rust 1.63 (in current stable Debian), and dashmap 5.5+ has a higher MSRV. (dashmap is a dependency of lightningcss, the CSS parser currently used) I had to add that for the CI test with 1.63 to pass.

Do you need the CSS feature? If not then making it optional and enabled with the css feature would be fine.

In the slightly longer term I'm replacing lightningcss (which is also relatively huge) with a much smaller CSS parser which won't have the dashmap dependency at all.

@xmakro
Copy link
Author

xmakro commented May 2, 2024

Thanks, I changed it to optional, that works for my case. Hopefully in the future this version pinning can be avoided:
rust-lang/rfcs#3537
rust-lang/cargo#9930

@jugglerchris jugglerchris merged commit 5309464 into jugglerchris:main May 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants