disable unsafe 'end' syntax #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.43%@@ master #748 diff @@
==========================================
Files 18 17 -1
Lines 4014 4018 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3511 3513 +2
- Misses 503 505 +2
Partials 0 0
|
|
@joehuchette, okay with this fix? |
|
Thanks, Miles. I can cherry-pick to release-0.12 and push a patch release tomorrow, if you don't beat me to it. |
|
I'm planning on releasing 0.13 tomorrow unless there are any objections. Do we actually need to patch 0.12? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reimplement
sizeonce JuliaLang/julia#16104 is resolved, but in the meantime I don't think we have a choice but to turnendinto an error because it can lead to surprisingly incorrect user code.Ref #730