Update to Octave version 9 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tk_plotly.cpp
Outdated
| @@ -539,7 +539,8 @@ std::string plotly_graphics_toolkit::getObjectNumber( | |||
| ) const | |||
| { | |||
| double h = o.get_handle().value(); | |||
| unsigned long id = *reinterpret_cast<unsigned long*>(&h); | |||
| unsigned long id; | |||
| std::memcpy(&id, &h, sizeof(h)); | |||
There was a problem hiding this comment.
I think we should be able to do this with a proper reinterpret cast.
There was a problem hiding this comment.
Yeah the original thing would do, just had a warning out of it
/home/runner/work/xeus-octave/xeus-octave/src/tk_plotly.cpp:542:23: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
542 | unsigned long id = *reinterpret_cast<unsigned long*>(&h);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hence introduced the change, can revert if required.
Let me revert the change, this can be looked into later too
There was a problem hiding this comment.
Let's keep the warning. I think the original code with the double looks like it needs clarification 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.