Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dep on ipython_genutils #1726

Closed
wants to merge 1 commit into from
Closed

Conversation

henryiii
Copy link

@henryiii henryiii commented Mar 10, 2022

@@ -224,7 +224,8 @@ def get_data_files():
'pandocfilters>=1.4.1',
'testpath',
'defusedxml',
'nbclient>=0.5.0,<0.6.0'
'nbclient>=0.5.0,<0.6.0',
'ipython_genutils',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'ipython_genutils',
'ipython-genutils',

Could write it this way instead.

Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like the correct play for now

@davidbrochart
Copy link
Member

davidbrochart commented Mar 11, 2022

I dropped ipython_genutils in nbclient, since it was mostly used to handle python2/python3 compatibility. Maybe we can do the same here, instead of depending on it?

@davidbrochart
Copy link
Member

mmm it seems it's not only about py2/3 compat here, so maybe it's fine to still depend on it.
I don't like the about section of ipython_genutils though: "Vestigial IPython utilities: DO NOT USE" 😄

bilke added a commit to ufz/ogs that referenced this pull request Mar 11, 2022
@blink1073
Copy link
Contributor

Closing in favor of #1727. Thanks @henryiii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named ipython_genutils
4 participants