Allow pre-fetch of css files without attempting download #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll make a patch release tomorrow. |
|
Great, thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for pre-fetching of css files (outside of the build system) without first attempting a download (which on some non-internet connected systems may cause the installation to hang indefinitely). Specifically, it rearranges the logic in hatch_build.py, checking to see whether the destination file exists before attempting a download (if the destination exists, then the
_get_css_filefunction returns). I have tested installing on internet-connected systems (i.e., the normal way), as well as on non-internet connected systems with the css files pre-fetched through Spack (as resources).Fixes #2093