Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for tests/ dir not in sys.path, closes #2066 #2108

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix for tests/ dir not in sys.path, closes #2066 #2108

merged 1 commit into from
Feb 9, 2024

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Feb 9, 2024

It's still a bit of a mystery to me why these tests pass on CI, but this closes #2066 for me on two different operating systems.

@ivanov ivanov mentioned this pull request Feb 9, 2024
Closed
@ivanov ivanov mentioned this pull request Feb 9, 2024
Open
blink1073
blink1073 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 3a37b54 into main Feb 9, 2024
24 checks passed
@blink1073 blink1073 deleted the pi/fix-2066 branch February 9, 2024 01:49
@ivanov
Copy link
Member Author

ivanov commented Feb 9, 2024

thank you, Steve!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest is failing in two tests/test_nbconvertapp.py units (7.11.0 - 7.16.0)
2 participants
@ivanov @blink1073