Adapted number regex to allow scientific notation #490
Conversation
| const DECIMAL_DOT_SEPARATOR_REGEX = /^[+-]?([0-9]*[.])?[0-9]+$/; | ||
|
|
||
| const INTEGER_REGEX = /^[+-]?[0-9]+$/; | ||
| const NUMBER_REGEX = /^[+-]?([0-9]*[,\\.])?[0-9]+([eE][+\\-]?\d+)?$/; |
There was a problem hiding this comment.
I'm curious; what does the [,\\.] do?
I only know this syntax here to indicate a logical "or": [,|.].
But I assume that is not what you want to express?
There was a problem hiding this comment.
To my knowledge the logical or exists, so ,|\. would be , or .. With the bracers, you define a group of characters that satisfy the regex, so [,\.] is "one of , or ." which is functionally identical to ,|\.. The difference starts with things like [0-9] that you could write as 0|1|2|3|4|5|6|7|8|9.
But since we have used [+-] before (and use [eE] later), I think sticking to these two character groups makes sense as well. Even though, seeing this I am not sure why I introduced the double escape in the second [+-].
There was a problem hiding this comment.
Wouldn't then that sub-expression mean "one of the following: , or \ or any character" since the backslash is escaped instead of the fullstop?
There was a problem hiding this comment.
Yeah, I changed this again to not use the escaping character. I think (from the regex testers I used), the escape works as desired but it is just not needed in this case.
| /** | ||
| * Reuse decimal number parsing to capture valid scientific notation | ||
| * of integers like 5.3e3 = 5300. In contrast to decimal, if the final number | ||
| * is not a valid integer, returns undefined. | ||
| */ |
Probably, even though my hope is still that we will write parsers in Jayvee so they can be extended by users. I'd then move the notation documentation into their docs and autogenerate docs from there as we do for blocks. Otherwise I fear documentation will quickly get out of sync with implementation. |
rhazn
force-pushed
the
issue-488-allow-scientific-notation
branch
from
0e2a24c
to
8b68399
Compare
Allows parsing numbers in scientific notation, both integers like 1.904761905e+20 or decimals like 8.1e-5.
Closes #488