Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --parse-only flag #492

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Add --parse-only flag #492

merged 10 commits into from
Jan 9, 2024

Conversation

joluj
Copy link
Contributor

@joluj joluj commented Dec 21, 2023

This PR adds a --parse-only flag to the interpreter. Using this flag, the app just parses (and therefore validates) the given Jayvee model without executing it.

The process (when called with --parse-only) ends with 0 in case of valid model, with 1 otherwise.

rhazn
rhazn requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. If I am not mistaken the tests are not testing what you want them to test though, that is what my request for changes is about.

apps/interpreter/src/parse-only.spec.ts Show resolved Hide resolved
apps/interpreter/src/run-action.ts Outdated Show resolved Hide resolved
apps/interpreter/src/index.ts Outdated Show resolved Hide resolved
apps/interpreter/src/parse-only.spec.ts Show resolved Hide resolved
apps/interpreter/src/parse-only.spec.ts Show resolved Hide resolved
rhazn
rhazn requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. If I am not mistaken the tests are not testing what you want them to test though, that is what my request for changes is about.

@joluj joluj requested a review from rhazn December 31, 2023 11:52
rhazn
rhazn approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small style comment but overall happy with having this merged without further review 👍 .

apps/interpreter/src/parse-only.spec.ts Outdated Show resolved Hide resolved
apps/interpreter/src/parse-only.spec.ts Outdated Show resolved Hide resolved
@joluj joluj merged commit faecf34 into main Jan 9, 2024
2 checks passed
@joluj joluj deleted the parse-only branch January 9, 2024 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhazn rhazn rhazn approved these changes

@georg-schwarz georg-schwarz georg-schwarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joluj @rhazn @georg-schwarz