Simplify checking for incorrect extractor and loader blocks #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georg-schwarz
changed the title
joluj
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
The error message better but not very good imo. Why does it say SQLiteLoader if the block is a CarsLoader?
Maybe change it to
The output type "None" of CarsLoader (as an SQLiteLoader) is incompatible with the input type "TextFile" of CarsCSVInterpreter (as a CSVInterpreter)
or simpler (preferred):
The output type "None" of CarsLoader is incompatible with the input type "TextFile" of CarsCSVInterpreter
georg-schwarz
force-pushed
the
simplify-validation-incorrect-extractor-loader
branch
from
e9e9fca
to
8e68450
Compare
georg-schwarz
force-pushed
the
simplify-validation-incorrect-extractor-loader
branch
from
8e68450
to
35e5247
Compare
joluj
approved these changes
Jan 16, 2024
| @@ -81,9 +61,18 @@ function checkPipesOfBlock( | |||
| isCompositeBlocktypeDefinition(block.$container) && | |||
| block.$container.blocks.at(0)?.name === block.name; | |||
|
|
|||
| const isExtractorBlock = !blockType.hasInput() && whatToCheck === 'input'; | |||
There was a problem hiding this comment.
Naming is somewhat confusing since it may be an ExtractorBlock even if we don't check for it.
There was a problem hiding this comment.
Will be refactored in a future PR.
georg-schwarz
changed the title
georg-schwarz
deleted the
simplify-validation-incorrect-extractor-loader
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of fixing #497, I'd like to simplify some validations.
I plan to refactor all validations in
validateBlockDefinitionbecause they should rather be located invalidatePipelineDefinitionandvalidateCompositeBlockTypeDefinition.In this attempt, I noticed that we can simplify the validation whether a loader is connected via its output port, and whether an extractor is connected via its input port.
Improved the validation messages along the way..
Before
After
I think the error message is clear enough to cover this edge case as well.