Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor block validation multiple pipe inputs #506

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

georg-schwarz
Copy link
Member

  • Changed logic to iterate over pipeline structure.
  • Adapted some tests to be more precise

Validation output should have stayed roughly the same (except some minor edge cases)

@georg-schwarz
Copy link
Member Author

georg-schwarz commented Jan 17, 2024

A discussion emerged from this regarding #485 between @joluj and me. Probably of interest to @rhazn
For the sake of completeness, here a condensed version. The discussion needs to be continued somewhere else I think.

We currently don't model instances. This works until now as we prohibit scenarios where a block is reused by different inputting blocks (this validation was refactored in this PR). The question is if this is really desirable. If we allow it, we might run into ambiguous behavior.

Our takeaway was that we need to think ahead about how we want to model blocks with different ports (e.g., for merging different tables). This seems to be the stage where we need to model instances. We did a whiteboard session on this, and it feelt really difficult to do without an instantiation logic where you can indicate whether a block is the same instance or if there are different instances of a block. This is probably the origin for this feedback.

@georg-schwarz georg-schwarz merged commit ea04e0a into main Jan 17, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the refactor-block-validation-multiple-pipe-inputs branch January 17, 2024 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants