Add health-check support to loadbalancer #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9757 +/- ##
==========================================
- Coverage 52.94% 46.48% -6.47%
==========================================
Files 154 154
Lines 13601 13679 +78
==========================================
- Hits 7201 6358 -843
- Misses 5038 6100 +1062
+ Partials 1362 1221 -141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
loadbalancer-enhancements
branch
11 times, most recently
from
6db4ff3
to
07af6b7
Compare
dereknola
previously approved these changes
Mar 21, 2024
brandond
force-pushed
the
loadbalancer-enhancements
branch
4 times, most recently
from
a5a3877
to
e4e6c35
Compare
* Adds support for health-checking loadbalancer servers. If a health-check fails when dialing, all existing connections to the server will be closed. * Wires up a remotedialer tunnel connectivity check as the health check for supervisor/apiserver connections. * Wires up a simple ping request to the supervisor port as the health check for etcd connections. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
loadbalancer-enhancements
branch
from
e4e6c35
to
f4ff494
Compare
dereknola
approved these changes
Mar 27, 2024
briandowns
approved these changes
Mar 27, 2024
galal-hussein
approved these changes
Mar 27, 2024
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add health-check support to loadbalancer
This ensures that any load-balanced connections to a node will be closed when the remotedialer tunnel to that node disconnects. This isn't much of an issue on K3s as the apiserver always exits when the supervisor shuts down, but on RKE2 the apiserver may continue running even when the supervisor stops, but without its load-balanced connection to etcd. This change will ensure that agents and etcd-only nodes disconnect from an apiserver when its supervisor goes down. Similarly, apiservers will fail over to a different etcd server when an etcd node's supervisor goes down.
Types of Changes
enhancement / bugfix
Verification
See linked RKE2 issue
There is no effective change to K3s, as the apiserver and etcd always exit when the supervisor exits, which forces clients to disconnect. The change is only apparent on RKE2, where the pods can continue running in a degraded state after the supervisor exits.
Testing
Linked Issues
User-Facing Change
Further Comments