Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.22 #112

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Update go to 1.22 #112

merged 7 commits into from
Feb 16, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented Feb 15, 2024

@kachick
flake.lock: Update
42f07d1 
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/f9d39fb9aff0efee4a3d5f4a6d7c17701d38a1d8' (2024-02-11)
  → 'github:NixOS/nixpkgs/35ff7e87ee05199a8003f438ec11a174bcbd98ea' (2024-02-13)
@kachick
Bump go version to 1.22 in flake
e80e69d
@kachick
go get go@1.22
23c7f27
@kachick
Prefer vendorHash rather than deprecated vendorSha256
1855038
@kachick
Copy link
Owner Author

kachick commented Feb 15, 2024

https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112

task: [lint] staticcheck ./...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x713452]

goroutine 222 [running]:
honnef.co/go/tools/go/ir.memberFromObject(0xc008aa1710, {0x0, 0x0?}, {0x0?, 0x0})
	honnef.co/go/tools/go/ir/create.go:54 +0x52
honnef.co/go/tools/go/ir.membersFromDecl(0xc008aa1710, {0xa0[29](https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112#step:8:30)[38](https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112#step:8:39)?, 0xc0005db7c0?})
	honnef.co/go/tools/go/ir/create.go:155 +0x297
honnef.co/go/tools/go/ir.(*Program).CreatePackage(0xc000a257a0, 0xc0087f84e0, {0xc001b45128, 0x1, 0x1}, 0xc001977810, 0x0)
	honnef.co/go/tools/go/ir/create.go:207 +0x7a5
honnef.co/go/tools/internal/passes/buildir.run(0xc0001ec820)
	honnef.co/go/tools/internal/passes/buildir/buildir.go:85 +0x165
honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc0015a79e0, {0xa04268?, 0xc0000c7[40](https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112#step:8:41)0})
	honnef.co/go/tools/lintcmd/runner/runner.go:992 +0x6fd
honnef.co/go/tools/lintcmd/runner.genericHandle({0xa04268?, 0xc0000c7400}, {0xa04268?, 0xc0000c72c0?}, 0x8bb800?, 0x0, 0xc000b29078)
	honnef.co/go/tools/lintcmd/runner/runner.go:817 +0x129
honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers(0xc000167db0, 0xc00021d7a0, 0xc0019776d0)
	honnef.co/go/tools/lintcmd/runner/runner.go:1065 +0x716
honnef.co/go/tools/lintcmd/runner.(*subrunner).doUncached(0x0?, 0xc00021d7a0)
	honnef.co/go/tools/lintcmd/runner/runner.go:720 +0x189
honnef.co/go/tools/lintcmd/runner.(*subrunner).do(0xc000167db0, {0xa042b0?, 0xc00021d7a0})
	honnef.co/go/tools/lintcmd/runner/runner.go:577 +0x94b
honnef.co/go/tools/lintcmd/runner.(*Runner).Run.func2({0xa042b0?, 0xc00021d7a0?})
	honnef.co/go/tools/lintcmd/runner/runner.go:1268 +0x2a
honnef.co/go/tools/lintcmd/runner.genericHandle({0xa042b0?, 0xc00021d7a0}, {0xa042b0?, 0xc00021d680?}, 0x0?, 0xc000442810, 0xc00096[41](https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112#step:8:42)80)
	honnef.co/go/tools/lintcmd/runner/runner.go:817 +0x129
created by honnef.co/go/tools/lintcmd/runner.(*Runner).Run in goroutine 1
	honnef.co/go/tools/lintcmd/runner/runner.go:1267 +0x[50](https://github.com/kachick/selfup/actions/runs/7911644844/job/21596126453?pr=112#step:8:51)5
exit status 2

🤷‍♂️

dominikh/go-tools#1495
dominikh/go-tools#1496

@kachick kachick changed the title Update go 122 Update go to 1.22 Feb 15, 2024
@kachick kachick marked this pull request as draft February 15, 2024 05:52
kachick
kachick commented Feb 16, 2024
View reviewed changes
Taskfile.yml
@@ -45,7 +45,6 @@ tasks:
- goreleaser check
- typos . .github .vscode
- nixpkgs-fmt --check ./*.nix
- staticcheck ./...
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kachick/go-tools#1 may fix this problem, but ... in the first place, I want only faster tools as go vet...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/golang/go/blob/go1.22.0/src/cmd/vet/README#L1-L33 😍

@kachick kachick marked this pull request as ready for review February 16, 2024 12:24
@kachick kachick merged commit 160ca78 into main Feb 16, 2024
9 checks passed
@kachick kachick deleted the update-go-122 branch February 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kachick