Skip to content

Commit

Permalink
Completely drop ncc with esbuild bundler (#570)
Browse files Browse the repository at this point in the history
* `npm uninstall @vercel/ncc`

* Completely drop ncc with esbuild bundler

* Try to avoid error when esbuild bundled

```Dynamic require of "x + " is not supported```

https://github.com/kachick/wait-other-jobs/actions/runs/5999518469/job/16269833936?pr=570

* Add missing path

* Remove unnecessary waiting another job since removed many dependencies

* Needed this change for appear path
  • Loading branch information
kachick committed Aug 28, 2023
1 parent 38bee8f commit 09a92e1
Show file tree
Hide file tree
Showing 7 changed files with 7,524 additions and 9,492 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ on:
jobs:
build:
timeout-minutes: 15
needs: [typecheck] # Ensuring cache
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
12 changes: 0 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,3 @@ false
> readableDuration(4200)
'about 4 seconds'
```

## Why using ncc and esbuild?

Honestly I want to have only one tool. However keeping ncc for compatibility. Quote from [esbuild documents](https://github.com/esbuild/esbuild.github.io/blob/b431563203d117c4cf9f467481960aeaabcc0fde/src/content/getting-started.yml#L268-L314).

```
You also may not want to bundle your dependencies with esbuild. There are many node-specific features that esbuild doesn't support while bundling such as __dirname, import.meta.url, fs.readFileSync, and *.node native binary modules. You can exclude all of your dependencies from the bundle by setting packages to external:
esbuild app.jsx --bundle --platform=node --packages=external
If you do this, your dependencies must still be present on the file system at run-time since they are no longer included in the bundle.
```
Loading

0 comments on commit 09a92e1

Please sign in to comment.