Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide devcontainer #517

Merged
merged 37 commits into from
Jun 27, 2023
Merged

Provide devcontainer #517

merged 37 commits into from
Jun 27, 2023

Conversation

kachick
Copy link
Owner

@kachick kachick commented Jun 24, 2023

https://stackoverflow.com/questions/75653182/why-do-some-official-nix-docker-containers-not-have-the-nixos-rebuild-command

https://qiita.com/anagura0000/items/bef08bf129f1bd8529ce

https://developers.redhat.com/blog/2014/05/05/running-systemd-within-docker-container

https://hub.docker.com/r/nixos/nix/dockerfile

https://github.com/NixOS/nix/blob/fd4f03b8fdcb0f33552730c786139019e29f5dbe/scripts/install-multi-user.sh#L260

NixOS/nix#4219 (comment)

https://stackoverflow.com/questions/66146088/docker-failed-to-compute-cache-key-not-found-runs-fine-in-visual-studio

https://zenn.dev/streamwest1629/articles/vscode_wanderer-in-devcontainer

https://vlike-vlife.netlify.app/posts/vscode_remote_container_command

devcontainers/cli#398

https://stackoverflow.com/questions/1250079/how-to-escape-single-quotes-within-single-quoted-strings

dprint/dprint-vscode#38

microsoft/vscode-remote-release#4209 (comment)

https://discourse.nixos.org/t/per-user-profiles-not-created-when-home-mounted-on-nfs/5864/3

microsoft/vscode-remote-release#4646

devcontainers/ci#176 (comment)

microsoft/vscode-remote-release#2402

microsoft/vscode-remote-release#2228

https://zenn.dev/hankei6km/articles/userns-remap-in-gha-ubuntu-runner

actions/runner-images#6631

https://github.com/rootless-containers/rootlesskit

https://blog.amedama.jp/entry/docker-container-host-same-user-bis

https://zenn.dev/anyakichi/articles/73765814e57cba

https://containers.dev/implementors/json_reference/

https://zenn.dev/forrep/articles/8c0304ad420c8e

microsoft/vscode-remote-release#3545

uses: devcontainers/ci@v0.3
with:
# https://github.com/devcontainers/ci/issues/176#issuecomment-1291232544
skipContainerUserIdUpdate: true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachick kachick mentioned this pull request Jun 27, 2023
@kachick kachick marked this pull request as ready for review June 27, 2023 12:56
@kachick kachick merged commit e386674 into main Jun 27, 2023
12 checks passed
@kachick kachick deleted the docker-or-devcontainer branch June 27, 2023 12:58
Comment on lines +22 to +25
# daemon mode required systemd, docker disables it
# As I understand the definition https://hub.docker.com/r/nixos/nix/dockerfile at Nix 2.17, it looks like a single user installation(no-daemon)
# See https://github.com/NixOS/nix/blob/fd4f03b8fdcb0f33552730c786139019e29f5dbe/scripts/install-nix-from-closure.sh#L129-L139
RUN bash <(curl -L https://nixos.org/nix/install) --no-daemon --yes
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +19 to +20
# The install scripts will be syntax error if it will be eval with dash
SHELL ["/bin/bash", "-c"]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/nix#4896 Looks same issue

kachick added a commit to kachick/devcontainer-ubuntu-nix that referenced this pull request Mar 3, 2024
@kachick kachick mentioned this pull request Mar 23, 2024
kachick added a commit that referenced this pull request Mar 23, 2024
Revert #517

- Now I'm using podman, I can't quickly test the docker based devcontainer stack
- CI took longtime
- AFAIK, there is no devcontainer user in contributors. If not, please tell me 🙏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant