Skip to content

Commit

Permalink
Fix Algolia search link positioning (mmistakes#1904)
Browse files Browse the repository at this point in the history
* Add link for testing purposes
* Fix excerpt link positioning in Algolia search results
* Fix Algolia search input color
* Update CHANGELOG and history

Fixes mmistakes#1903
  • Loading branch information
mmistakes committed Oct 22, 2018
1 parent 5a2c37a commit 90b3325
Show file tree
Hide file tree
Showing 8 changed files with 44 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Enhancements

- Fix Algolia search link positioning. [#1904](https://github.com/mmistakes/minimal-mistakes/pull/1904)
- Update Lunr to `2.3.3`. [#1885](https://github.com/mmistakes/minimal-mistakes/pull/1885)
- Cache "static" includes to improve build performance. **Note:** The theme uses the [jekyll-include-cache](https://github.com/benbalter/jekyll-include-cache) plugin which will need to be installed in your `Gemfile` and added to the `plugins` array of `_config.yml`. Otherwise you'll throw `Unknown tag 'include_cached'` errors at build. [#1874](https://github.com/mmistakes/minimal-mistakes/pull/1874)
- Make entire feature and archive items "clickable". [#1864](https://github.com/mmistakes/minimal-mistakes/pull/1864)
Expand Down
35 changes: 26 additions & 9 deletions _sass/minimal-mistakes/_archive.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,6 @@

.archive__item {
position: relative;

a::before {
content: '';
position: absolute;
left: 0;
top: 0;
right: 0;
bottom: 0;
}
}

.archive__subtitle {
Expand All @@ -50,6 +41,15 @@
overflow: hidden;
text-overflow: ellipsis;

a::before {
content: '';
position: absolute;
left: 0;
top: 0;
right: 0;
bottom: 0;
}

a + a {
opacity: 0.5;
}
Expand All @@ -70,6 +70,10 @@
& + p {
text-indent: 0;
}

a {
position: relative;
}
}

.archive__item-teaser {
Expand Down Expand Up @@ -281,6 +285,10 @@
clear: both;
font-size: 1.125em;

.archive__item {
float: left;
}

.archive__item-teaser {
margin-bottom: 2em;
}
Expand Down Expand Up @@ -318,6 +326,10 @@
clear: both;
font-size: 1.125em;

.archive__item {
float: left;
}

.archive__item-teaser {
margin-bottom: 2em;
}
Expand Down Expand Up @@ -357,6 +369,11 @@
clear: both;
font-size: 1.125em;

.archive__item {
float: left;
width: 100%;
}

.archive__item-teaser {
margin-bottom: 2em;
}
Expand Down
4 changes: 2 additions & 2 deletions _sass/minimal-mistakes/_search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@
}

.archive__item-title .ais-Highlight {
color: $link-color;
color: $primary-color;
font-style: normal;
text-decoration: underline;
}
.archive__item-excerpt .ais-Highlight {
color: $link-color;
color: $primary-color;
font-style: normal;
font-weight: bold;
}
4 changes: 4 additions & 0 deletions _sass/minimal-mistakes/skins/_dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,7 @@ $base0f: #cc6633 !default;
.page__footer-follow .social-icons .svg-inline--fa {
color: inherit;
}

.ais-search-box .ais-search-box--input {
background-color: $form-background-color;
}
4 changes: 4 additions & 0 deletions _sass/minimal-mistakes/skins/_neon.scss
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,7 @@ $base0f: #cc6633 !default;
color: $text-color;
}
}

.ais-search-box .ais-search-box--input {
background-color: $form-background-color;
}
4 changes: 4 additions & 0 deletions _sass/minimal-mistakes/skins/_plum.scss
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,7 @@ $base0f: #cc6633 !default;
color: $text-color;
}
}

.ais-search-box .ais-search-box--input {
background-color: $form-background-color;
}
3 changes: 2 additions & 1 deletion docs/_docs/18-history.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ permalink: /docs/history/
excerpt: "Change log of enhancements and bug fixes made to the theme."
sidebar:
nav: docs
last_modified_at: 2018-10-09T14:49:28-04:00
last_modified_at: 2018-10-22T13:55:29-04:00
toc: true
---

## Unreleased

### Enhancements

- Fix Algolia search link positioning. [#1904](https://github.com/mmistakes/minimal-mistakes/pull/1904)
- Update Lunr to `2.3.3`. [#1885](https://github.com/mmistakes/minimal-mistakes/pull/1885)
- Cache "static" includes to improve build performance. **Note:** The theme uses the [jekyll-include-cache](https://github.com/benbalter/jekyll-include-cache) plugin which will need to be installed in your `Gemfile` and added to the `plugins` array of `_config.yml`. Otherwise you'll throw `Unknown tag 'include_cached'` errors at build. [#1874]
- Make entire feature and archive items "clickable". [#1864](https://github.com/mmistakes/minimal-mistakes/pull/1864)
Expand Down
2 changes: 1 addition & 1 deletion test/_posts/2016-02-24-welcome-to-jekyll.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ tags:
- update
---

You'll find this post in your `_posts` directory. Go ahead and edit it and re-build the site to see your changes. You can rebuild the site in many different ways, but the most common way is to run `jekyll serve`, which launches a web server and auto-regenerates your site when a file is updated.
You'll find this post in your `_posts` directory. Go ahead and edit it and re-build the site to see your changes. You can rebuild the site in [many different ways](https://jekyllrb.com/docs/usage/), but the most common way is to run `jekyll serve`, which launches a web server and auto-regenerates your site when a file is updated.

To add new posts, simply add a file in the `_posts` directory that follows the convention `YYYY-MM-DD-name-of-post.ext` and includes the necessary front matter. Take a look at the source for this post to get an idea about how it works.

Expand Down

0 comments on commit 90b3325

Please sign in to comment.