Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2340: Enhance karate summary report #2477

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

codehackerr
Copy link
Contributor

@codehackerr codehackerr commented Jan 13, 2024

-  Add skipped scenario count
-  Add pass percentage
-  Add totals row

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

    -  Add skipped scenario count
    -  Add pass percentage
    -  Add totals row
@codehackerr
Copy link
Contributor Author

The approach is detailed here:
#2340 (comment)

@ptrthomas ptrthomas merged commit f3007c6 into karatelabs:develop Jan 18, 2024
1 check passed
@edwardsph
Copy link
Contributor

Something to note - this is a breaking change i.e. getScenariosTotal becomes getRunScenariosTotal and Results is a public interface so I think this will need highlighting in a change log.

@ptrthomas
Copy link
Member

@codehackerr do you think we can keep it as getScenariosTotal- tagging @rc2201 because I think this was requested by only that team :| i haven't seen any other team care about skipped scenarios

@ptrthomas
Copy link
Member

changes reverted in 8b91147

@codehackerr
Copy link
Contributor Author

@ptrthomas do you want me to reopen with the name getScenariosTotal reinstated ?

@ptrthomas
Copy link
Member

@codehackerr no I would hold for now, most teams are fine with karate - and if anyone needs a custom report they can write their own: https://stackoverflow.com/a/66773839/143475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants