property override fix #2474

[dvargas46]

Description

Minimal solution to fix the issue of overriding runner properties by JVM args.

• Relevant Issues : karate 1.4.1- Dynamic property ( set in runner) not overridden from maven command #2474
• Relevant PRs : fix system properties issue on runner #2474 #2479
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[dvargas46]

@ptrthomas this PR removes setting the System property from the systemProperty method on the runner to fix this issue. Otherwise the other fix I considered of "syncing" the karate properties with the System properties ended up breaking other tests. Since it lead to a case where, in a multi-runner execution, one runner setting a property would override all other runners that needed to set the same property - e.g., if server.port is set on runner 1, then subsequent runners could not set the same property anymore and it would be forced to use whatever the first runner set it to unless it was explicitly cleared first.. I don't think that would be desirable, especially for mocks where the runners can use this method to set server port details.

If setting the System property is still needed in the systemProperty method for something else, then this issue may become more challenging to deal with. My first thought would be to cache the System properties initially, so that we could have a reference of what properties came from JVM arguments and use that to override each time the runner needs to reference it, while still maintaining an actual sync across runner and system properties elsewhere. Let me know if you have any thoughts on which direction we should take here.