Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

Don't use the root property to determine suite root. #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lddubeau
Copy link

@lddubeau lddubeau commented Oct 5, 2017

The root property is problematic because Mocha sets it true if the
description of a suite is the empty string. However, Mocha runs
perfectly well with suites that have empty names. See:

mochajs/mocha#2755

Instead of relying on the root property, rely on whether the parent
property is set. If not, then we are at the root.

The root property is problematic because Mocha sets it true if the
description of a suite is the empty string. However, Mocha runs
perfectly well with suites that have empty names. See:

mochajs/mocha#2755

Instead of relying on the root property, rely on whether the parent
property is set. If not, then we are at the root.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@lddubeau
Copy link
Author

lddubeau commented Oct 5, 2017

I signed the CLA.

The failing tests are not due to the changes I made but to a misconfiguration of the Travis parameters (which I did not touch).

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants