-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add script to deploy k8s metrics-server in member cluster #3650
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3650 +/- ##
==========================================
- Coverage 56.62% 56.62% -0.01%
==========================================
Files 221 221
Lines 20838 20838
==========================================
- Hits 11800 11799 -1
- Misses 8416 8417 +1
Partials 622 622
Flags with carried forward coverage won't be shown. Click here to find out more. |
cc @Poor12 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using a MAC M1 PC, and it's possible that the Let me investigate this issue first. |
Nice finding! I don't have a Mac on my hand, please help test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwcesign
In order to make it easier for contributors to try it on their local machine, I think we should add some examples or test reports to this PR description.
Added |
Signed-off-by: jwcesign <jiangwei115@huawei.com>
cc @chaunceyjiang, hello, please check again, it works fine on my Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
When using FederatedHPA,
metrics-server
needs to be installed in member clusters.So we provider a script to install
metrics-server
in member cluster conveniently.Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
Testing report:
Does this PR introduce a user-facing change?: